RE: logpipe error handling patch

From: James Powell <james4591_at_hotmail.com>
Date: Tue, 29 Jul 2014 13:08:37 -0700

Yeah its a workaround but I've implemented it anyway in my LFS hint to be sure it works right.

If you don't mind me asking Jan, can I host it on the runit-for-LFS project on GoogleCode?

Sent from my Windows Phone
________________________________
From: Jan Pobrislo<mailto:ccx_at_webprojekty.cz>
Sent: ‎7/‎29/‎2014 1:00 PM
To: supervision_at_list.skarnet.org<mailto:supervision_at_list.skarnet.org>
Subject: Re: logpipe error handling patch

On Tue, 29 Jul 2014 15:22:36 +0000
Gerrit Pape <pape_at_smarden.org> wrote:

> Thanks for the patch, but it works around the bug and doesn't fix its
> root cause.

There are two possible resolutions - either make runsv create new pipe
when asked to start up again or make it die since it's unable to spawn
a child. My patch implements latter (because it's the simpler of
possible resolutions) and will not break anything if the former is ever
implemented. runsv instance that passes wrong filedescriptors to its
child is broken and should be killed so it can be respawned.

I can try to implement some more graceful behaviour if you can think of
one, but I'd still like to see this patch included as it doesn't break
anything - it's just a sanity check.
Received on Tue Jul 29 2014 - 20:08:37 UTC

This archive was generated by hypermail 2.3.0 : Sun May 09 2021 - 19:44:18 UTC